Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Startup perf don't await pty host connection on web #229992

Merged
merged 1 commit into from
Sep 27, 2024
Merged

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Sep 27, 2024

Fixes #229944

@Tyriar Tyriar added this to the October 2024 milestone Sep 27, 2024
@Tyriar Tyriar self-assigned this Sep 27, 2024
Copy link
Member

@bpasero bpasero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we usually use environmentService.remoteAuthority to probe for a remote?

@Tyriar Tyriar merged commit 83e902b into main Sep 27, 2024
7 checks passed
@Tyriar Tyriar deleted the tyriar/229944 branch September 27, 2024 19:09
@Tyriar
Copy link
Member Author

Tyriar commented Sep 27, 2024

@bpasero will change 👍

@Tyriar
Copy link
Member Author

Tyriar commented Sep 27, 2024

#230006

@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Nov 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Web: perf editor never finishes loading
3 participants